]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
network: Don't assume captive portal indicates wi-fi
authorMichael Catanzaro <mcatanzaro@redhat.com>
Wed, 21 May 2025 11:38:45 +0000 (06:38 -0500)
committerFlorian Müllner <fmuellner@gnome.org>
Mon, 9 Jun 2025 19:40:06 +0000 (21:40 +0200)
Turns out my AT&T Internet gateway acts as a captive portal for about
two minutes after it is started. It's wrong to assume captive portal
indicates Wi-Fi.

Also, change the terminology from "Sign Into" to "Sign In to" to be
pedantic. "Sign Into" seems to be pretty widely used on the web, so
maybe users won't notice, but "Into" is supposed to be a preposition,
not a verb.

Closes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8330

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3717>

js/ui/status/network.js

index 69337ca993c672b53730d07c73116cc718d177e1..4b5ff47253a270eb19a3125bde7adea80fbbbe25 100644 (file)
@@ -1980,7 +1980,7 @@ class CaptivePortalHandler extends Signals.EventEmitter {
         const source = MessageTray.getSystemSource();
 
         const notification = new MessageTray.Notification({
-            title: _('Sign Into Wi–Fi Network'),
+            title: _('Sign in to Network'),
             body: name,
             source,
         });